Issue #3974 Deploying mysql-ha jar file into its own path...#3975
Issue #3974 Deploying mysql-ha jar file into its own path...#3975yadvr merged 1 commit intoapache:mainfrom
Conversation
|
@ggoodrich-ipp can you direct this fix to 4.13, please? |
|
@DaanHoogland I apologize for not getting around to this PR sooner. Can you please advise if I need to apply this to a different branch, or can it be included in master? Thanks! |
|
ah, np. I don't know if we want to still include it in older versions. @rhtyd ? |
|
ping @ggoodrich-ipp is this still relevant, and rebase to latest |
ggoodrich-ipp
force-pushed
the
gjg-csusage-mysqlha-fix
branch
from
453512c to
ece83c5
Compare
Yes, I believe it is still relevant. I've updated it against main. |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 266 |
|
@ggoodrich-ipp looks good but I only see centos7 changes. Is this specific to centos7? |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
It appears it could also be applied to centos8. Would you like me to make those changes? |
It isn't needed, right? would just be consistent? |
|
Trillian test result (tid-998)
|
@ggoodrich-ipp any update on changes (for centos8)? |
@ggoodrich-ipp any update on this PR? |
…low for easy inclusion of just this jar file into multiple packages, such as cloudstack-management and cloudstack-usage. Support for centos7 and centos8
ggoodrich-ipp
force-pushed
the
gjg-csusage-mysqlha-fix
branch
from
ece83c5 to
e7741e7
Compare
@sureshanaparti I've made the centos8 changes. I don't have a way to test these, however, as we have no centos8 systems implemented. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 536 |
|
Trillian test result (tid-1287)
|
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 584 |
|
@ggoodrich-ipp @sureshanaparti @rhtyd the centos8 doesn't build because of the agent scripts not being able to find |
|
Trillian Build Failed (tid-1314) |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 805 |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian Build Failed (tid-1580) |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian Build Failed (tid-1592) |
|
@blueorangutan test keepEnv |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1604)
|
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1677)
|
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
LGTM - have not tested it
|
@rhtyd @DaanHoogland can you review? |
|
The fact that smoke tests pass now is good enough for me, as it proves the point that the move of the jar works (for centos7). LGTM |
|
Lgtm, didn't manually test it which is not necessary based on spec and class path changes. |
7 participants
...to allow for easy inclusion of just this jar file into multiple packages, such as cloudstack-management and cloudstack-usage.
Description
Prior PR #2915 causes the cloudstack-usage daemon to not be able to find the mysql-ha jar file.
This happens because the /etc/default/cloudstack-usage file points to the old location for the mysql-ha jar file, and thus is unable to load it. This prior PR installs this jar into a more common area with other jar files, and thus is not really a desired location for the cloudstack-usage daemon to get it from, as it will cause cloudstack-usage to load other plugins that it doesn't need.
Fixes: #3974
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?